Fixes #5380. Remove local Terminal.Gui.Editor package hack#5386
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/gui-cs/Terminal.Gui/blob/863694a3aa30358181461629ade4168a637552b8/local_packages/Terminal.Gui.2.2.2-local.nupkg#L1
Deleting the committed local_packages/*.nupkg/*.snupkg files makes the repository fail its own parallel unit-test job: Tests/UnitTestsParallelizable/LocalPackagesTests.cs asserts that local_packages exists and contains at least one .nupkg and .snupkg (LocalPackagesFolderExists, NupkgFilesExist, SnupkgFilesExist), and .github/workflows/unit-tests.yml runs that test project directly without a preceding dotnet pack step to repopulate the folder. In a fresh checkout, this change leaves no artifacts to satisfy those assertions, so CI will break until tests or workflow are updated in the same change.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tig
force-pushed
the
tig/fix-bind-platformkeybinding-namespace
branch
from
863694a to
9225923
Compare
- Update Directory.Packages.props: Terminal.Gui.Editor version 2.2.6-local -> 2.4.1 - Restore Terminal.Gui.Editor package pattern in nuget.config for nuget source - Delete local_packages/*.nupkg hack files - Delete LocalPackagesTests.cs (tested the hack, no longer applicable) Terminal.Gui.Editor 2.4.1 is now on nuget.org targeting Terminal.Gui 2.4.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
Summary
Removes the temporary local package workaround introduced in PR #5378.
Changes
Terminal.Gui.Editorversion2.2.6-local→2.4.1(real NuGet package)<package pattern="Terminal.Gui.Editor" />under thenugetpackageSource so it resolves from nuget.org.nupkg/.snupkgfiles:Terminal.Gui.2.2.2-local.nupkgTerminal.Gui.2.2.2-local.snupkgTerminal.Gui.Editor.2.2.6-local.nupkgContext
Terminal.Gui.Editor 2.4.1 is now published on nuget.org, targeting Terminal.Gui ≥ 2.4.0 (with the
Bind/PlatformKeyBindingnamespace fix from #5369). The local package hack is no longer needed.Verification
dotnet restore✅dotnet build✅ (0 errors)